chore: fix no-base-to-string #2597
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
core contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2597 +/- ##
==========================================
+ Coverage 94.81% 94.82% +0.01%
==========================================
Files 1225 1226 +1
Lines 27481 27557 +76
Branches 6187 6210 +23
==========================================
+ Hits 26056 26131 +75
- Misses 1367 1368 +1
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChrisChV
left a comment
ChrisChV
left a comment
There was a problem hiding this comment.
Looks good! 👍
- I read through the code and considered the security, stability and performance implications of the changes.
github-project-automation
bot
moved this from Ready for Review
to Done
in Contributions
3 participants
Description
In a few places on in the code we are calling
.toString()on an object with a type likeReadableStream<Uint8Array<ArrayBuffer>> | BodyInit | null | undefined. Because this could be an object, oxlint is warning us against using.toString()which will just return a string like[object Object]or[object ArrayBuffer]. However, it turns out that in each case the type is already astringso we don't need to be calling.toString()at all.Rule documentation:
Part of #2559
Private ref MNG-4763